Introduce recursive shower mop-up algorithms at the end of the Pandora reconstruction#845
Introduce recursive shower mop-up algorithms at the end of the Pandora reconstruction#845
Conversation
cerati
left a comment
cerati
left a comment
There was a problem hiding this comment.
I am not an expert on the details of the pandora xml, but I definitely support adding this algorithm to the chain!
acampani
left a comment
acampani
left a comment
There was a problem hiding this comment.
I discussed the details of the inclusion of these algorithms in the chain with Dom B. and other Pandora experts from SBND and prepared the sequence that Riccardo tested and validated in extensive detail so, given the positive results of the change, I approve this PR and the inclusion of the mop up as part of Pandora reconstruction.
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
trigger build larsoft@v10_20_04 LArSoft/lar*@LARSOFT_SUITE_v10_20_04 SBNSoftware/sbnalg@v10_20_04 SBNSoftware/sbnobj@v10_20_04 SBNSoftware/sbnanaobj@v10_20_04 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbncode@v10_20_04 SBNSoftware/icarusutil@v10_15_00 SBNSoftware/icaruscode@v10_20_03 |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored failure for unit_test - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored failure for unit_test - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
5 participants
This PR introduces the recursive shower mop-up algorithms (
LArRecursivePfoMopUp) towards the end of the reconstruction, after the track-shower PFP characterization. This initial implementation was agreed with reconstruction experts and SBND collaborators. The updated XML from this PR was used for all the tests performed in the past few months (e.g., SBN DocDB 39622).Review
Tagging for review: @acampani, @brucehoward-physics, @cerati.
Thanks!